Having upgraded an 8.8.15_P45 system (on Rocky) to 10.0.6 using the standard zm_build scripts a bug in the sources is encountered.
Upon starting the services, mailbox and the related webapps failed to start.
Looking in /opt/zimbra/log/zmmailboxd.out I found the problem
It doesn't specifically call out the offending XML file but I started with what I thought would be the obvious one - /opt/zimbra/jetty_base/etc/jetty.xml
Sure enough jetty.xml has "--" in line 989 at column 13.
Line 989The problem arises because the comment marks around this line are contained in a larger comment block - commenting out HTTPCOMPRESSION
but the presense of comment marks nested inside a comment block breaks the parser rules. See screenshot of code editor - you can see that the presense of the nested comment breaks the larger comment block.XML Comments Rules
Following rules should be followed for XML comments −
Comments cannot appear before XML declaration.
Comments may appear anywhere in a document.
Comments must not appear within attribute values.
Comments cannot be nested inside the other comments.
Deleting the nested comment from line 976 of jetty.xml.in,
saving the file,
and running zmmailbocdctl restart
fixes the issue and allows mailbox and the webapps to start.
I have no understanding of where the various source files are stored in the various Zimbra GitHub projects so I am hoping someone from zimbra will take up this issue, log it to github, and fix it.
Upon starting the services, mailbox and the related webapps failed to start.
Looking in /opt/zimbra/log/zmmailboxd.out I found the problem
Code:
2023-10-25 17:16:29.432:INFO::main: Logging initialized @5114ms to org.eclipse.jetty.util.log.StdErrLog2023-10-25 17:16:30.419:WARN:oejx.XmlParser:main: FATAL@null line:989 col:13 : org.xml.sax.SAXParseException; lineNumber: 989; columnNumber: 13; The string "--" is not permitted within comments.2023-10-25 17:16:30.420:WARN:oejx.XmlConfiguration:main: java.security.PrivilegedActionException: org.xml.sax.SAXParseException; lineNumber: 989; columnNumber: 13; The string "--" is not permitted within comments.at java.base/java.security.AccessController.doPrivileged(AccessController.java:573)at org.eclipse.jetty.xml.XmlConfiguration.main(XmlConfiguration.java:1857)at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)at java.base/java.lang.reflect.Method.invoke(Method.java:568)at org.eclipse.jetty.start.Main.invokeMain(Main.java:218)at org.eclipse.jetty.start.Main.start(Main.java:491)at org.eclipse.jetty.start.Main.main(Main.java:77)Caused by: org.xml.sax.SAXParseException; lineNumber: 989; columnNumber: 13; The string "--" is not permitted within comments.Sure enough jetty.xml has "--" in line 989 at column 13.
Line 989
Code:
<!-- Modern UI uses build time compression -->Code:
<!-- HTTPCOMPRESSIONBEGIN <Get id="next" name="handler" /> <Set name="handler"> <New id="GzipHandler" class="org.eclipse.jetty.server.handler.gzip.GzipHandler"> <Set name="handler"><Ref refid="next" /></Set> <Set name="minGzipSize"><Property name="jetty.gzip.minGzipSize" deprecated="gzip.minGzipSize" default="2048"/></Set> <Set name="checkGzExists"><Property name="jetty.gzip.checkGzExists" deprecated="gzip.checkGzExists" default="false"/></Set> <Set name="compressionLevel"><Property name="jetty.gzip.compressionLevel" deprecated="gzip.compressionLevel" default="-1"/></Set> <Set name="excludedAgentPatterns"> <Array type="String"> <Item><Property name="jetty.gzip.excludedUserAgent" deprecated="gzip.excludedUserAgent" default=".*MSIE.6\.0.*"/></Item> </Array> </Set> <Set name="includedMethods"> <Array type="String"> <Item>GET</Item> <Item>POST</Item> </Array> </Set> <!-- Modern UI uses build time compression --> <Set name="excludedPaths"> <Array type="String"> <Item>/modern/*</Item> </Array> </Set> </New> </Set> HTTPCOMPRESSIONEND -->but the presense of comment marks nested inside a comment block breaks the parser rules. See screenshot of code editor - you can see that the presense of the nested comment breaks the larger comment block.
Following rules should be followed for XML comments −
Comments cannot appear before XML declaration.
Comments may appear anywhere in a document.
Comments must not appear within attribute values.
Comments cannot be nested inside the other comments.
Deleting the nested comment from line 976 of jetty.xml.in,
saving the file,
and running zmmailbocdctl restart
fixes the issue and allows mailbox and the webapps to start.
I have no understanding of where the various source files are stored in the various Zimbra GitHub projects so I am hoping someone from zimbra will take up this issue, log it to github, and fix it.
Statistics: Posted by liverpoolfcfan — Mon Jan 15, 2024 5:29 pm